🧱 Mason: Refactor Momentum Equations (Fixes OCP/Primitive Obsession) #385
Conversation
This commit introduces the `MomentumEquation` trait to decouple the flow regime (Navier-Stokes vs Euler) from the solver logic. It also introduces a `SpatialGradients` parameter object to encapsulate the various gradient terms, reducing parameter bloat. Key changes: - Added `SpatialGradients` and `FluidError` to `types.rs`. - Defined `MomentumEquation` trait in `conservation.rs`. - Implemented `NavierStokes` and `Euler` strategies. - Updated `navier_stokes_time_derivative` and `euler_time_derivative` to return `Result` and use the strategies. - Updated tests to handle `Result` propagation. This addresses OCP and Primitive Obsession violations. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This commit introduces the `MomentumEquation` trait to decouple the flow regime (Navier-Stokes vs Euler) from the solver logic. It also introduces a `SpatialGradients` parameter object to encapsulate the various gradient terms, reducing parameter bloat. Key changes: - Added `SpatialGradients` and `FluidError` to `types.rs`. - Defined `MomentumEquation` trait in `conservation.rs`. - Implemented `NavierStokes` and `Euler` strategies. - Updated `navier_stokes_time_derivative` and `euler_time_derivative` to return `Result` and use the strategies. - Updated tests to handle `Result` propagation. - Formatted code with `cargo fmt`. This addresses OCP and Primitive Obsession violations. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Refactored
math_explorer/src/physics/fluid_dynamics/conservation.rsto use the Strategy Pattern for momentum equations. IntroducedSpatialGradientsto reduce parameter lists. Updated public API to returnResult<Vector3<f64>, FluidError>instead of rawVector3<f64>to enforce error handling.PR created automatically by Jules for task 9939918684997605650 started by @fderuiter