Safety Refactor: Climate, Game Theory, and Radar Gating #382
Conversation
- Refactored `math_explorer/src/climate/loss.rs` to use `total_cmp` for safe NaN handling in EMD calculation. - Refactored `math_explorer/src/applied/game_theory/evolutionary.rs` to return `Result` from simulation methods and handle population extinction. - Refactored `math_explorer/src/physics/medical/radar_gating/super_resolution.rs` to check for NaNs in MUSIC estimator and use safe sorting. - Refactored `math_explorer/src/applied/algorithms/sorting/linear.rs` to remove `expect`. - Added `PopulationExtinction` to `GameTheoryError` and `NumericalInstability` to `RadarError`. - Added tests for NaN handling. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR addresses several safety issues and technical debts:
loss.rs): Replacedunwrap()insort_bywithtotal_cmp. This prevents panics if NaN values are present in the distributions being compared for Earth Mover's Distance.evolutionary.rs): ChangedReplicatorDynamics::simulateto returnResult. Added a check for population extinction (sum near zero) to prevent division by zero / NaN propagation.super_resolution.rs): Added validation inMusicEstimator::compute_spectrumto check for NaN eigenvalues before sorting. AddedNumericalInstabilityerror variant.linear.rs): Replacedexpectwithunwrap_or(&0)inRadixSorterfor cleaner, panic-free code (though it was guarded).Tests were added and updated to verify these changes.
cargo clippyandcargo fmtwere run.PR created automatically by Jules for task 7102040448943071072 started by @fderuiter