⚙️ Core: Refactor Dose Calculation Strategy #379
Conversation
- Defined `DoseError` enum for typed error handling. - Introduced `TermaInput` and `KernelInput` parameter objects with strict validation. - Extracted `TermaModel` and `DoseKernel` traits to decouple algorithms. - Implemented `ExponentialTerma` and `PointSpreadKernel` strategies. - Deprecated legacy functions `calculate_terma` and `point_kernel`, delegating to new strategies. - Added comprehensive unit tests for validation and strategy logic. This refactor addresses Primitive Obsession and improves Composability/OCP. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Ran `cargo fmt` to address CI failure. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
⚙️ Core: Refactor Dose Calculation Strategy
🔧 The Violation:
The
dose_calculation.rsmodule relied on "Primitive Obsession" (passing rawf64s) and violated the Open/Closed Principle (adding a new kernel would require modifying existing code). It also used stringly-typed errors.🛠️ The Fix:
Applied the Strategy Pattern and Parameter Object Pattern.
TermaInputandKernelInputencapsulate arguments and enforce invariants (e.g., non-negative fluence) at construction time ("Parse, don't validate").TermaModelandDoseKerneltraits allow users to inject custom physics models without touching the core logic.DoseErrorto replaceStringerrors.📉 Debt Reduction:
🧪 Integrity:
PR created automatically by Jules for task 2593254931381143047 started by @fderuiter