🧱 Mason: Decouple Momentum Equations (Fixes OCP) #377
Conversation
- Introduced `MomentumEquation` trait in `conservation.rs`. - Implemented `NavierStokes` and `Euler` strategies. - Added `SpatialGradients` in `types.rs` to unify method signatures. - Added `FluidError` for structured error handling. - Deprecated original functions `navier_stokes_time_derivative` and `euler_time_derivative`, reimplementing them as wrappers for backward compatibility. - Added unit tests for new strategies. This refactor resolves an OCP violation where adding new physics models required modifying the core conservation module. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Introduced `MomentumEquation` trait in `conservation.rs`. - Implemented `NavierStokes` and `Euler` strategies. - Added `SpatialGradients` in `types.rs` to unify method signatures. - Added `FluidError` for structured error handling. - Deprecated original functions `navier_stokes_time_derivative` and `euler_time_derivative`, reimplementing them as wrappers for backward compatibility. - Added unit tests for new strategies. This refactor resolves an OCP violation where adding new physics models required modifying the core conservation module. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
🧱 Mason: Decouple Momentum Equations (Fixes OCP)
conservation.rsmodule violated OCP by hardcodingnavier_stokes_time_derivativeandeuler_time_derivativeas separate functions, making it impossible to add new physics models without modifying the module.MomentumEquationtrait, withNavierStokesandEulerstrategies. IntroducedSpatialGradientsparameter object.PR created automatically by Jules for task 10265248665521159239 started by @fderuiter