Refactor ListGetEndpointMixin to use hook for special parameters #615
Conversation
Refactors `ListGetEndpointMixin` to support a `_extract_special_params` hook, allowing subclasses to extract and process specific filter parameters without overriding the entire `_list_impl` method. Updates `UsersEndpoint` and `RecordsEndpoint` to use this hook, removing redundant `_list_impl` overrides and improving code reuse and maintainability. Addresses code review feedback by ensuring special params are extracted before `_auto_filter` runs, preserving behavior. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Refactored
ListGetEndpointMixinto introduce_extract_special_paramshook.Updated
UsersEndpointto remove_list_imploverride and use the hook forinclude_inactive.Updated
RecordsEndpointto remove_list_imploverride and use the hook forrecord_data_filter.Cleaned up unused imports in
imednet/endpoints/users.pyandimednet/endpoints/records.py.Ensured
_extract_special_paramsis called before_auto_filterto prevent potential parameter loss.Verified changes with unit tests.
PR created automatically by Jules for task 4366427379489499289 started by @fderuiter