Skip to content

Conversation

@KirCute
Copy link
Contributor

@KirCute KirCute commented Feb 27, 2025

Modify the type of PassiveTransferPortRange in the driver settings to the interface PasvPortGetter, which is essentially a function that can return the exposed port and the listened port. The listened port will be listened by the local host, while the exposed port will be returned as the result of the PASV or EPSV command. This design ensures that the library can adapt to cases where port mapping exists between the client and server, such as deployment within Docker.

PortRange implemented PasvPortGetter, so the modified version will remain compatible with previous versions.

@fclairamb fclairamb enabled auto-merge (squash) May 4, 2025 21:44
@fclairamb
Copy link
Owner

I like how you implemented it !

@fclairamb fclairamb disabled auto-merge May 4, 2025 21:44
@fclairamb fclairamb enabled auto-merge (squash) May 4, 2025 21:44
@codecov
Copy link

codecov bot commented May 4, 2025

Codecov Report

Attention: Patch coverage is 64.28571% with 10 lines in your changes missing coverage. Please review.

Project coverage is 86.54%. Comparing base (d4ec1a1) to head (677bec6).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
driver.go 50.00% 5 Missing ⚠️
transfer_pasv.go 72.22% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
- Coverage   86.68%   86.54%   -0.14%     
==========================================
  Files          11       12       +1     
  Lines        2328     2342      +14     
==========================================
+ Hits         2018     2027       +9     
- Misses        236      240       +4     
- Partials       74       75       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fclairamb
Copy link
Owner

Hum, reducing coverage is not cool.

@KirCute
Copy link
Contributor Author

KirCute commented May 6, 2025

Hum, reducing coverage is not cool.

Sorry, I’ve been much busier lately compared to when I submitted this PR, so I might not have the chance to add tests for now. I’ll probably have more free time in the next month or two.

@cursor
Copy link

cursor bot commented Jun 4, 2025

🚨 BugBot failed to run

Remote branch not found for this Pull Request. It may have been merged or deleted (requestId: serverGenReqId_12c0d4e2-4a27-476d-a352-48a1aafb858c).

@KirCute
Copy link
Contributor Author

KirCute commented Jun 12, 2025

It seems the relevant changes have already been merged into PR #540, so I'll close this PR now.

@KirCute KirCute closed this Jun 12, 2025
auto-merge was automatically disabled June 12, 2025 07:38

Pull request was closed

@KirCute KirCute deleted the feat/pasv-port-mapping branch June 14, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants