This repository was archived by the owner on May 8, 2024. It is now read-only.
FcitxQtKeySequenceWidget: fix meta key handling#45
Open
ishitatsuyuki wants to merge 1 commit intofcitx:masterfrom
Open
FcitxQtKeySequenceWidget: fix meta key handling#45ishitatsuyuki wants to merge 1 commit intofcitx:masterfrom
ishitatsuyuki wants to merge 1 commit intofcitx:masterfrom
Conversation
fcitx-kcm refuses to accept shortcuts like Meta-Space without this patch. It also gives Unicode salad when only Meta key is pressed. The code was sourced from the latest KDE equivalent of this function, which is KeySequenceRecorderPrivate::handleKeyPress from KGuiAddons.
Author
|
@wengxt mind reviewing this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fcitx-kcm refuses to accept shortcuts like Meta-Space without this patch.
It also gives Unicode salad when only Meta key is pressed.
The code was sourced from the latest KDE equivalent of this function,
which is KeySequenceRecorderPrivate::handleKeyPress from KGuiAddons.