feat: enhance PartnerCatalogSerializer to support email regexes #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alec4r
approved these changes
Dec 2, 2025
Ang-m4
force-pushed
the
afg/learner-views
branch
from
8ea0be2 to
3afdd6b
Compare
Ang-m4
force-pushed
the
afg/email-regex-api-simplification
branch
from
6c5a376 to
c27f474
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the
CatalogEmailRegexendpoints completely in order to simplify the API, leveraging the PUT/PATCH methods at the catalog level instead.Why is this important?
We didn’t really need a full CRUD endpoint just to manage the email regexes assigned to a single catalog.
Now we can handle the creation and deletion of a catalog’s email regexes through the serializer
update()function.I also restricted the manager edit access to only the required attributes, as specified.
How to test
PUTorPATCHrequest to/manage/catalogs/<id>/adding or removing email regex entries.You should see the updated list of email regexes reflected in the response.
nameoruser_limit).A validation error should be thrown and the change should be rejected.