Implement a simple 'strip prefix' feature for http locations #5276
Open
cayspekko wants to merge 2 commits intofatedier:devfrom
Open
Implement a simple 'strip prefix' feature for http locations #5276cayspekko wants to merge 2 commits intofatedier:devfrom
cayspekko wants to merge 2 commits intofatedier:devfrom
Conversation
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (8 files)
Reviewed by gpt-5.4-20260305 · 291,463 tokens |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY
Though frpproxy isn't meant to be a full blown L7 reverse proxy, this particular feature is useful if you use multiple dynamic paths on the server, but you don't want to hassle with url prefix logic on your http client. Especially useful for http clients that serve pure json apis. In my particular case, I cannot use domain based identifiers. Fit's naturally with the "locations" setting, and thus it only strips those particularly prefixes as they are defined.
Example:
relates to #4981