feat: add multi-arch Docker build support with backward compatibility #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `multi_arch` input (default: false) to workflows for gradual rollout - Add matrix strategy for parallel builds on native amd64/arm64 runners - Create new `create-manifest` action for combining platform-specific images - Update `build-publish-docker` to push images with arch suffix - Update `build-image` to create platform-specific artifacts - Update `load-image-publish` to handle single/multi-arch manifests When multi_arch=false (default): only amd64 is built, manifest created with just amd64, preserving backward-compatible tags (e.g., oneclick-123) When multi_arch=true: both amd64 and arm64 built in parallel, multi-arch manifest created pointing to both images Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Temporarily point all action references to the feature branch for testing before merging to main. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The matrix context is not available in job-level `if` conditions for reusable workflows. Moving the condition to step-level where matrix context is available. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Pass through the multi_arch input to load-image-publish action so it can properly handle multi-arch artifact publishing. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ch is disabled Use fromJSON to dynamically build the matrix based on multi_arch input. When multi_arch=false (default), only amd64 runner is launched. When multi_arch=true, both amd64 and arm64 runners are launched. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use custom job name to keep 'build-service' for amd64 builds and only add '-arm64' suffix for arm64 builds. This maintains backward compatibility with existing required checks configuration. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
multi_archinput (default: false) to all Docker workflows for gradual rolloutcreate-manifestaction that combines platform-specific images into a single manifestChanges
create-manifest/action.ymlbuild-publish-docker/action.ymlbuild-image/action.ymlload-image-publish/action.ymlmulti_archinputdocker-service.ymldocker-api-service.ymldocker-service-build.ymlHow it works
Intermediate images (internal, not consumed directly):
oneclick-123-amd64- amd64 platform imageoneclick-123-arm64- arm64 platform image (only when multi_arch=true)Final manifest tag (what consumers use - unchanged):
oneclick-123→ manifest pointing to available platform imagesmulti_archfalse(default)oneclick-123trueoneclick-123Test plan
multi_arch=false(default)oneclick-123without arch suffix)multi_arch=trueonce arm64 runner (ubuntu-arm64-latest) is available🤖 Generated with Claude Code