Skip to content

Fix plugin folder resolution for metrics creation #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NonSwag merged 1 commit into from
Jan 2, 2026
Merged

Fix plugin folder resolution for metrics creation #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion bukkit/src/main/java/dev/faststats/bukkit/BukkitMetricsImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import org.jetbrains.annotations.Contract;
import org.jspecify.annotations.Nullable;

import java.io.File;
import java.nio.file.Path;
import java.util.Optional;
import java.util.function.Supplier;
Expand Down Expand Up @@ -93,9 +94,17 @@ private <T> Optional<T> tryOrEmpty(Supplier<T> supplier) {
static final class Factory extends SimpleMetrics.Factory<Plugin> {
@Override
public Metrics create(Plugin plugin) throws IllegalStateException {
var dataFolder = plugin.getServer().getPluginsFolder().toPath().resolve("faststats");
var dataFolder = getPluginsFolder(plugin).resolve("faststats");
var config = dataFolder.resolve("config.properties");
return new BukkitMetricsImpl(this, plugin, config);
}

private static Path getPluginsFolder(Plugin plugin) {
try {
return plugin.getServer().getPluginsFolder().toPath();
} catch (NoSuchMethodError e) {
return plugin.getDataFolder().getParentFile().toPath();
}
}
}
}
Loading