Skip to content

Add BUILD_ID tracking to metrics and error reports #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NonSwag merged 1 commit into from
Mar 22, 2026
Merged

Add BUILD_ID tracking to metrics and error reports #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/main/java/dev/faststats/core/SimpleErrorTracker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,13 @@ public void trackError(final Throwable error) {
}
}

public JsonArray getData() {
public JsonArray getData(final String buildId) {
final var report = new JsonArray(reports.size());

reports.forEach((hash, object) -> {
final var copy = object.deepCopy();
copy.addProperty("hash", hash);
copy.addProperty("buildId", buildId);
final var count = collected.getOrDefault(hash, 1);
if (count > 1) copy.addProperty("count", count);
report.add(copy);
Expand Down
4 changes: 3 additions & 1 deletion core/src/main/java/dev/faststats/core/SimpleMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ public abstract class SimpleMetrics implements Metrics {

private final String SDK_NAME;
private final String SDK_VERSION;
private final String BUILD_ID;

{
final var properties = new Properties();
Expand All @@ -60,6 +61,7 @@ public abstract class SimpleMetrics implements Metrics {
}
this.SDK_NAME = properties.getProperty("name", "unknown");
this.SDK_VERSION = properties.getProperty("version", "unknown");
this.BUILD_ID = properties.getProperty("build-id", "unknown");
}

@Contract(mutates = "io")
Expand Down Expand Up @@ -278,7 +280,7 @@ protected JsonObject createData() {
data.add("data", metrics);

getErrorTracker().map(SimpleErrorTracker.class::cast)
.map(SimpleErrorTracker::getData)
.map(tracker -> tracker.getData(BUILD_ID))
.filter(errors -> !errors.isEmpty())
.ifPresent(errors -> data.add("errors", errors));
return data;
Expand Down