dynamic island boundary#3
Merged
EstebanAce merged 4 commits intofastscape-lem:masterfrom Sep 22, 2025
Merged
Conversation
benbovy
approved these changes
Sep 22, 2025
Member
benbovy
left a comment
benbovy
left a comment
There was a problem hiding this comment.
Sorry @EstebanAce for the long wait. This looks good to me, just added a very minor suggestion. Thanks!
Co-authored-by: Benoit Bovy <benbovy@gmail.com>
Collaborator
Author
|
No worries! Thanks for the suggestion. I proceed to do the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to set the island boundary to change with topography_elevation during the simulation rather to be fixed and defined at the beginning of the model run.