Skip to content

Comments

failing to recognized individuals#2

Merged
EstebanAce merged 2 commits intofastscape-lem:masterfrom
EstebanAce:master
May 9, 2025
Merged

failing to recognized individuals#2
EstebanAce merged 2 commits intofastscape-lem:masterfrom
EstebanAce:master

Conversation

@EstebanAce
Copy link
Collaborator

Jean found a bug in which some of the individuals were not detected when one set up a polygon (island-like environment) on the bounded dispersal option. We fixed the bug by modifying the condition.

@EstebanAce EstebanAce requested a review from benbovy May 8, 2025 21:21
@EstebanAce EstebanAce changed the title failing to recognized individuals in first triangle failing to recognized individuals May 8, 2025
@EstebanAce EstebanAce added the bug Something isn't working label May 8, 2025
Copy link
Member

@benbovy benbovy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EstebanAce, this looks good to me!

- toytree
- toyplot
- pytest
- zarr<3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is safer indeed. We'll probably need some work in xarray-simlab to support Zarr v3.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look! I'll merge it on then.

@EstebanAce EstebanAce merged commit c2eaab3 into fastscape-lem:master May 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants