use sha256 instead of sha1#3
Open
matbech wants to merge 1 commit intofastnloud:masterfrom
matbech:patch-1
Open
use sha256 instead of sha1#3matbech wants to merge 1 commit intofastnloud:masterfrom matbech:patch-1
matbech wants to merge 1 commit intofastnloud:masterfrom
matbech:patch-1
Conversation
There is no (good) reason to use sha1 any longer. DKIM verifier are required (see RFC) to support sha1 and sha256. The following patch replaces sha1 with sha256.
Contributor
|
Hi @matbech, I tried to contact the original author of this project but he ignore me, so I decided to clone the entire project to another repository and include your improvement. You can find the project here: https://github.com/joepsyko/zf-dkim If you have any improvement please make a pull request there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no (good) reason to use sha1 any longer. DKIM verifier are required (see RFC) to support sha1 and sha256. The following patch replaces sha1 with sha256.