feat: Support for 404.ftd and 500.ftd catch-all pages#2214
Open
siddhantk232 wants to merge 6 commits intomainfrom
Open
feat: Support for 404.ftd and 500.ftd catch-all pages#2214siddhantk232 wants to merge 6 commits intomainfrom
siddhantk232 wants to merge 6 commits intomainfrom
Conversation
If a fastn package contains a 404.ftd file then visiting any 404 route (a route that does not exist) will render this 404.ftd file. For any other fastn error (error in syntax, calls to http processor failing etc), the 500.ftd in current fastn package will be rendered. when env DEBUG is set, the original error with a nicer message is shown instead to give the developer some more context. In production, the `--trace` output should be considered around these 404/500 requests to know about the cause.
Links from the book overwrite original doc links. This may result in some of the book links giving 404 pages. This is fixed by prefixing every Book route with /book/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a fastn package contains a 404.ftd file then visiting any 404 route
(a route that does not exist) will render this 404.ftd file.
For any other fastn error (error in syntax, calls to http processor
failing etc), the 500.ftd in current fastn package will be rendered.
when env DEBUG is set, the original error with a nicer message is shown
instead to give the developer some more context. In production, the
--traceoutput should be considered around these 404/500 requests toknow about the cause.