Skip to content

Conversation

@fasteiner
Copy link
Owner

Add Notion PDF and Video block creation functions with tests

  • Implemented New-NotionPdfBlock and New-NotionVideoBlock functions for creating Notion PDF and Video blocks.
  • Added unit tests for both functions to validate their functionality and input handling.
  • Removed unimplemented placeholder functions from the Cmds folder after relocating and implementing them.

Add Notion PDF and Video block creation functions with tests

- Implemented `New-NotionPdfBlock` and `New-NotionVideoBlock` functions for creating Notion PDF and Video blocks.
- Added unit tests for both functions to validate their functionality and input handling.
- Removed unimplemented placeholder functions from the Cmds folder after relocating and implementing them.
@fasteiner fasteiner marked this pull request as ready for review June 30, 2025 17:01
@fasteiner fasteiner requested a review from tsubotitsch June 30, 2025 17:01
Copy link
Collaborator

@tsubotitsch tsubotitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@fasteiner
Copy link
Owner Author

I just cecked the tests again, seems there is some issues that need to be fixed

@fasteiner fasteiner marked this pull request as draft July 1, 2025 14:15
@fasteiner
Copy link
Owner Author

Locally all tests are fixed now.

@fasteiner fasteiner marked this pull request as ready for review July 1, 2025 15:55
@fasteiner fasteiner merged commit 4d2bedb into main Jul 1, 2025
1 check failed
@fasteiner fasteiner deleted the feature/37-new--function-for-every-block-class branch July 1, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants