Skip to content

Conversation

@tisonkun
Copy link
Collaborator

No description provided.

Signed-off-by: tison <wander4096@gmail.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs cleanup work to improve documentation accuracy and test coverage for the OnceMap and singleflight::Group types. The changes include grammar corrections, test additions, and trait assertion tests.

Changes:

  • Fixed grammar error in OnceMap::discard documentation ("remove" → "removed")
  • Corrected CHANGELOG method name reference (Group::removeGroup::forget)
  • Added comprehensive test coverage for OnceMap and singleflight::Group including constructors, concurrent operations, and edge cases
  • Added trait assertions for Send, Sync, and Unpin for OnceMap and singleflight::Group

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
mea/src/once/once_map/mod.rs Fixed grammar in documentation comment (spelling correction)
CHANGELOG.md Corrected method name from remove to forget in API change description
mea/src/lib.rs Added trait assertions for OnceMap and singleflight::Group to verify they are Send, Sync, and Unpin
mea/src/once/once_map/tests.rs Added comprehensive tests for constructor methods, concurrent failure handling, removal during computation, and complex key types
mea/src/singleflight/tests.rs Added comprehensive tests for try_work method including simple cases, coalescing, failure handling, and concurrent retry scenarios

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tisonkun tisonkun merged commit 9760213 into main Jan 21, 2026
15 checks passed
@tisonkun tisonkun deleted the tidy branch January 21, 2026 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants