Fix #[trace] macro suppressing dead_code warnings #157
+25
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
#[trace]attribute macro was preventing the compiler from emitting dead_code warnings for unused functions.Root Cause
The macro used
quote!()to generate output, which doesn't preserve span information needed for lint attribution. Without proper spans, the compiler's dead_code analysis couldn't correctly identify unused functions.Changes
quote_spanned!()with the function identifier's span instead ofquote!()Example
Before this change, no warning was emitted:
After this change, the compiler correctly warns:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.