Skip to content

Conversation

@andylokandy
Copy link
Collaborator

@andylokandy andylokandy commented Dec 18, 2025

Closes #141

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a bridge function to convert fastrace's thread-local parent context into an OpenTelemetry SpanContext, enabling interoperability with OpenTelemetry-based instrumentation. It also includes minor refactoring of variable names in the global collector for improved clarity.

Key changes:

  • Introduces current_opentelemetry_context() function to extract the current fastrace local parent as an OpenTelemetry span context
  • Refactors variable naming in global_collector.rs to reduce verbosity and improve scoping
  • Updates documentation with examples demonstrating the new bridging functionality

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
fastrace/src/collector/global_collector.rs Refactored variable names from global_collector to collector for brevity and introduced scoped blocks to improve lock lifecycle management
fastrace-opentelemetry/src/lib.rs Added current_opentelemetry_context() function and renamed SpanContext import to OtelSpanContext to avoid naming conflicts
fastrace-opentelemetry/tests/context.rs Added integration test verifying that OpenTelemetry spans can be correctly parented by fastrace local parent spans
fastrace-opentelemetry/README.md Added new documentation section explaining how to activate OpenTelemetry trace context, fixed typo in "otlp", and updated dependency versions
fastrace-opentelemetry/Cargo.toml Added enable feature to fastrace dev-dependency for testing
fastrace-opentelemetry/CHANGELOG.md Added entry documenting the new helper functionality

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@andylokandy andylokandy merged commit 56001ec into fast:main Dec 18, 2025
11 checks passed
@andylokandy andylokandy deleted the dev-2 branch December 18, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opentelemetry Context in fastrace spans

1 participant