chore: code tidy over spsc #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR performs code tidying and cleanup on the SPSC (Single Producer Single Collector) module and related files. The changes focus on improving code clarity through better naming, refactoring, and removing unused code.
- Adds proper copyright headers and attribution to the derived SPSC implementation
- Refactors variable names for better clarity (
pending→pending_msgs) - Simplifies code patterns and removes unused imports/static variables
- Corrects spelling errors in comments
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
fastrace/src/util/spsc.rs |
Added copyright header with attribution, renamed pending field to pending_msgs, refactored bounded() and Drop implementations, changed visibility of is_under_pressure() to pub(crate) |
fastrace/src/util/command_bus.rs |
Updated copyright year from 2025 to 2024 |
fastrace/src/collector/global_collector.rs |
Removed unused imports (AtomicU64, Duration) and static REPORT_INTERVAL, fixed typo in comment ("collectior" → "collector"), refactored global collector loop to eliminate static variable access |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @andylokandy take anything that helps :D