ConcurrencyTest was not being executed, cleanup #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This change (#110cccb) helps to decouple "Operator" with its "precedence", in my opinion, "Operator" and its precedence should be separate, it smells like it is breaking single responsability principle, "Operator" is abstract and it is meant to be extended ... being able to access its class variables doesn't look right to me. |
Contributor
Author
|
I have refactored the code in Function.java class with an enum, this would help to avoid the coupling between class variables and the array, now we have all the logic in the enum ... we also got rid of indexing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.