Fix GRIP next uri when pushpin routes use path_beg and replace_beg#115
Open
timomeara wants to merge 1 commit intofanout:masterfrom
Open
Fix GRIP next uri when pushpin routes use path_beg and replace_beg#115timomeara wants to merge 1 commit intofanout:masterfrom
timomeara wants to merge 1 commit intofanout:masterfrom
Conversation
timomeara
commented
Apr 28, 2023
- adds django_eventstream.utils.build_next_uri method to build next uri
- use settings.EVENTSTREAM_PATH_PREPEND value if present to build correct next uri
… replace_beg is used
Member
|
Thanks for the report and PR! The change seems reasonable, although I'd think proxying to any Django app by subpath would have this problem and I wonder if there isn't a more general solution. For example, prepending the value of get_script_prefix. What do you think? |
Collaborator
|
Should we close this @jkarneges ? |
Member
|
Let's see if my suggestion would actually work, and if so then we can close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.