Fix: Handle invalid attendance timestamp (day out of range for month)#241
Closed
rafiqul-altersense wants to merge 1 commit intofananimi:masterfrom
rafiqul-altersense:master
Closed
Fix: Handle invalid attendance timestamp (day out of range for month)#241rafiqul-altersense wants to merge 1 commit intofananimi:masterfrom rafiqul-altersense:master
rafiqul-altersense wants to merge 1 commit intofananimi:masterfrom
rafiqul-altersense:master
Conversation
|
Why change something that not worth to change (eg code format), if i'm a reviewer i will never merge this |
Author
Sorry about that—my IDE auto-formatted the code. I've created a new pull request; please have a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update fixes a ValueError caused by invalid date values returned from the biometric device. The error occurred in zk.base.get_attendance() when trying to decode timestamps where the day value exceeded the valid range for a given month. A safeguard has been added to prevent this issue by validating or skipping malformed timestamps, ensuring the sync process doesn't crash.