fix: split attendance data by record size#166
Merged
kurenai-ryu merged 2 commits intofananimi:masterfrom Mar 15, 2023
Merged
Conversation
Contributor
Author
|
@fananimi @kurenai-ryu please have a look |
Contributor
Author
|
Related: #102 |
Collaborator
|
Hi, I made a 'cleaner' version, give a look, if you want, update this one so I can merge this one and close mine |
Contributor
Author
Thanks. I have made changes in this PR as well, you can merge either one. Let's get this live! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
record_sizeis greater than or equal to 40, we should be splitting the data by therecord_sizeand not by 40.In my case, the record size was 49, splitting by 40 gave me useless data.