Modification of the method "get_attendances"#138
Open
luislclams wants to merge 1 commit intofananimi:masterfrom
Open
Modification of the method "get_attendances"#138luislclams wants to merge 1 commit intofananimi:masterfrom
luislclams wants to merge 1 commit intofananimi:masterfrom
Conversation
Limit the number of records to get
housemateguy
approved these changes
May 5, 2022
|
When I use this method I usually get all attendance records in a variable and then filter them by the date (or DateTime) periods I want. this could be better if we instead get limit the records we get by the date. |
|
this PR is not for that. It helps to break the get_attendance in smaller blocks (not related to the date) did you review it properly? (with an actual device and that it still works correctly without argument?) I couldn't test it, and it seems fishy the usage of self.records (where it's cleared/seted ?) |
salsaidi
approved these changes
Jan 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limit the number of records to get