Open
Conversation
Collaborator
|
Deploy preview for famsf-insights ready! Built with commit 8bf5d0f |
Collaborator
Author
|
@doostinharrell - ready for your review. |
doostinharrell
suggested changes
Feb 8, 2019
Collaborator
doostinharrell
left a comment
doostinharrell
left a comment
There was a problem hiding this comment.
@thiagodemellobueno this works well if you start at the top of the page and scroll to the component. However if you use the url to deep link to the content the intended component is not displayed, you still see the intro slide, but you do see the viewport highlighting portion of the intended component.
src/components/molecules/zoom-image--fullbleed/_zoom-image--fullbleed.scss
Show resolved
Hide resolved
Collaborator
Author
|
@doostinharrell - ready to roll. |
// else {
// This was causing terrible terrible problems in mobile.
// $('.img-zoom-drag').closest('section.page').css('display', 'none');
// }
It causes the snap scroll bits too target a 0 height element (the hidden page) at the coordinate of (0,0) … thus snapping to what “seemed like” the story cover page, but not borking the code since as far as it was concerned that was perfectly fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When this is QA'd we can move the
zoom-image--fullbleedback into the late-monet.Currently it's in
https://deploy-preview-281--famsf-insights.netlify.com/for-testing/#&chapter=chapter_8383428&page=chapter_8413947
https://kalamuna.atlassian.net/browse/FDS-301