feat(disney): add featured offer slot with outbound tracking#972
Open
feat(disney): add featured offer slot with outbound tracking#972
Conversation
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Contributor
Haskell Test Coverage ReportGenerated by stack hpc report |
Collaborator
more info
|
Owner
Author
|
運用メモとして、実案件反映時に必要な作業を追記する 対応方法
必要であれば、次PRで |
Collaborator
more info
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
disney_experience_summary/go/:offerId/経由で遷移し、UTMを付与offer_clickを GA4 (gtag) イベントとして送信主な変更
contents/config/disney/Offers.dhallを追加(オファー定義)src/Rules/DisneyExperienceSummary.hsgo/:offerId/index.html)contents/pages/disney_experience_summary/jp.htmlfeatured-offer-slotを追加contents/scss/disney_experience_summary_only.scsscontents/ts/disney-tag-filter.ts.offer-linkクリック時にoffer_clickを計測contents/ts/__tests__/disney-tag-filter.test.ts動作確認
npm run testnpm run check:ts(既存 warning のみ)stack buildstack exec site -- builddocs/disney_experience_summary/jp.htmlに featured offer が描画されることを確認備考
Refs: #954, #957, #958, #959, #960, #961