Skip to content

Comments

feat: add pre commit#329

Merged
poiana merged 6 commits intofalcosecurity:mainfrom
idiap:feat/improve-pre-commit
Feb 19, 2026
Merged

feat: add pre commit#329
poiana merged 6 commits intofalcosecurity:mainfrom
idiap:feat/improve-pre-commit

Conversation

@sgaist
Copy link
Contributor

@sgaist sgaist commented Nov 7, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

Proposed rule maturity level

Uncomment one (or more) /area <> lines (only for PRs that add or modify rules):

/area maturity-stable

/area maturity-incubating

/area maturity-sandbox

/area maturity-deprecated

What this PR does / why we need it:

This PR adds pre-commit hooks to keep files clean (e.g. no trailing white spaces, etc.)

It also applies the hooks on the repo

Which issue(s) this PR fixes:

Fixes falcosecurity/falco#3727

Special notes for your reviewer:

@poiana poiana requested review from Kaizhe and darryk10 November 7, 2025 12:56
@poiana poiana added the size/XXL label Nov 7, 2025
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Rules files suggestions

falco_rules.yaml

Comparing 2a9ef9c65336be314043d5aef6630c1e4eab56dc with latest tag falco-rules-5.0.0

No changes detected

falco-sandbox_rules.yaml

Comparing 2a9ef9c65336be314043d5aef6630c1e4eab56dc with latest tag falco-sandbox-rules-6.0.0

No changes detected

falco-incubating_rules.yaml

Comparing 2a9ef9c65336be314043d5aef6630c1e4eab56dc with latest tag falco-incubating-rules-6.0.0

No changes detected

@poiana
Copy link

poiana commented Feb 5, 2026

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

leogr
leogr reviewed Feb 12, 2026
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sgaist,

Adding pre-commit hooks to keep the repo clean is a nice idea, thanks!

I just noticed the config references ./tools/local_hooks/dco-pre-commit-msg.sh but that file doesn't exist in this PR or anywhere in the repo.
So pre-commit install + commit would break.

Otherwise SGMT!

@sgaist sgaist force-pushed the feat/improve-pre-commit branch from e5d2f09 to 5898e3f Compare February 13, 2026 19:53
@leogr
Copy link
Member

leogr commented Feb 17, 2026

Hey @sgaist

Can you just rebase on top of the current main? Thanks 🙏

@sgaist
feat: add pre-commit hooks
4c799d4 
Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
@sgaist
chore: applied cleanup from pre-commit
d710909 
Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
@sgaist
chore: clean .pre-commit-config
fc35934 
Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
@sgaist
chore: add missing dco pre-commit msg script
d7fa6d9 
Don't forget to install the prepare-commit-mgs
hooks or it will not be used.

Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
@sgaist
feat: set default install hook types
ae817e3 
This ensures that the DCO hook is called

Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
@sgaist
chore: pre-commit autoupdate
b30bdcc 
Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
@sgaist sgaist force-pushed the feat/improve-pre-commit branch from 5898e3f to b30bdcc Compare February 17, 2026 11:56
@github-actions
Copy link

github-actions bot commented Feb 17, 2026

Rules files suggestions

falco-incubating_rules.yaml

Comparing 5a3934b0a88bd7d6108c963cde212c6a133894d5 with latest tag falco-incubating-rules-6.0.0

No changes detected

falco-sandbox_rules.yaml

Comparing 5a3934b0a88bd7d6108c963cde212c6a133894d5 with latest tag falco-sandbox-rules-6.0.0

Minor changes:

  • Rule Known Cryptominer Process Executed has been added
  • Rule Web Server Spawned Shell has been added
  • Rule Privileged Container Device Access has been added
  • Rule Network Tool Executed During NPM Package Install has been added
  • Rule Container Access to Host Sensitive Paths has been added
  • Rule Reverse Shell from Web Server has been added
  • Rule Web Server Spawned Suspicious Child Process has been added
  • Macro npm_package_install_ancestor has been added
  • Macro user_known_host_path_access has been added
  • Macro user_known_web_server_child_activities has been added
  • Macro network_tool_procs has been added
  • Macro user_known_privileged_device_access has been added
  • Macro spawned_by_web_server has been added
  • Macro is_miner_process has been added
  • Macro user_known_network_tool_in_npm_install_activities has been added
  • Macro user_known_web_server_shell_activities has been added
  • Macro known_container_runtime_host_access has been added
  • List miner_binaries has been added
  • List network_tool_binaries has been added
  • List node_package_managers has been added
  • List web_server_binaries has been added
  • List suspicious_web_children has been added

falco_rules.yaml

Comparing 5a3934b0a88bd7d6108c963cde212c6a133894d5 with latest tag falco-rules-5.0.0

Minor changes:

  • Macro postgres_running_cnpg has been added

Patch changes:

  • List read_sensitive_file_binaries has some item added or removed

leogr
leogr approved these changes Feb 19, 2026
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Feb 19, 2026
@poiana poiana added the lgtm label Feb 19, 2026
@poiana
Copy link

poiana commented Feb 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, sgaist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Feb 19, 2026

LGTM label has been added.

DetailsGit tree hash: bdbbaf9d14581ea50b47cb786a829dbe771e7932

@poiana poiana merged commit 21afd80 into falcosecurity:main Feb 19, 2026
17 of 18 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leogr leogr leogr approved these changes

@darryk10 darryk10 Awaiting requested review from darryk10

@Kaizhe Kaizhe Awaiting requested review from Kaizhe

Assignees

@leogr leogr

Labels

approved area/rules dco-signoff: yes kind/cleanup lgtm lifecycle/stale size/XXL

Projects

Falco Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Spaces should be trimmed from end of lines in rules file

3 participants

@sgaist @poiana @leogr