Led subsystem and command#48
Conversation
aaditsangvikar
left a comment
There was a problem hiding this comment.
Couple of changes needed, specifically with the way you're setting the pattern in the subsystem. Make sure you're removing all the tuning.json stuff as well.
There was a problem hiding this comment.
Couple other small changes
Edit:
Also this.animation is always null, I don't have much experience with CANdles but I doubt that is what is supposed to happen (maybe it is if you just want to set a constant color, if thats the case and we never want to do a pattern animation just set the animation to null and remove this.animation)
|
Is this looking better? |
|
Yea it looks a lot better thanks. One other thing, it doesn't look like you need |
|
I agree, thats an artifact.
|
|
The |
|
TotalTaxAmount
left a comment
There was a problem hiding this comment.
Looks good, we may have to add them back if we want to expand apon this to allow for real animations but this will work for now
No description provided.