Allow curve tree nodes to be both channels and parents#1320
Merged
facontidavide merged 2 commits intofacontidavide:mainfrom Mar 12, 2026
Merged
Allow curve tree nodes to be both channels and parents#1320facontidavide merged 2 commits intofacontidavide:mainfrom
facontidavide merged 2 commits intofacontidavide:mainfrom
Conversation
Owner
|
funny enough, I detected that yesterday. let me have a look at your proposed change |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fix a curve tree collision when a channel path is also a parent of other channels.
Details
When / separators are used, names like input/a and input/a/ad_raw can collide in the tree representation.
The issue is order-dependent: if input/a/ad_raw is inserted first, the input/a node is created as a parent branch, and the later insertion of the real input/a channel is effectively hidden.
This change allows a tree node to represent both a real channel and a parent node, so the shorter path is no longer lost.
A small CSV sample was added to datasamples/ to reproduce the issue.
Notes
This keeps the current drag behavior unchanged. If subtree dragging is added later, branch-vs-leaf behavior will likely need to be made more explicit in the UI.
Filtering on a node that is both a channel and a parent can still be somewhat ambiguous, but the current behavior is consistent with preserving both roles on the same row.
Possibly related to other path/tree representation issues such as #622, although the underlying cause here appears to be different.