Skip to content

Allow curve tree nodes to be both channels and parents#1320

Merged
facontidavide merged 2 commits intofacontidavide:mainfrom
phfix:fix/tree-leaf-parent-collision
Mar 12, 2026
Merged

Allow curve tree nodes to be both channels and parents#1320
facontidavide merged 2 commits intofacontidavide:mainfrom
phfix:fix/tree-leaf-parent-collision

Conversation

@phfix
Copy link
Contributor

@phfix phfix commented Mar 11, 2026

Summary

Fix a curve tree collision when a channel path is also a parent of other channels.

Details

When / separators are used, names like input/a and input/a/ad_raw can collide in the tree representation.

The issue is order-dependent: if input/a/ad_raw is inserted first, the input/a node is created as a parent branch, and the later insertion of the real input/a channel is effectively hidden.

This change allows a tree node to represent both a real channel and a parent node, so the shorter path is no longer lost.

A small CSV sample was added to datasamples/ to reproduce the issue.

Notes

This keeps the current drag behavior unchanged. If subtree dragging is added later, branch-vs-leaf behavior will likely need to be made more explicit in the UI.

Filtering on a node that is both a channel and a parent can still be somewhat ambiguous, but the current behavior is consistent with preserving both roles on the same row.

Possibly related to other path/tree representation issues such as #622, although the underlying cause here appears to be different.

@phfix phfix marked this pull request as ready for review March 11, 2026 16:32
@facontidavide
Copy link
Owner

funny enough, I detected that yesterday. let me have a look at your proposed change

@facontidavide facontidavide merged commit adc23c1 into facontidavide:main Mar 12, 2026
14 of 15 checks passed
@facontidavide
Copy link
Owner

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants