Fixed package version conflicts in install.sh#111
Fixed package version conflicts in install.sh#111ZachMckennedyFWig wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
When running the install.sh script I found 2 issues, the first was a conflict with the version of scipy being installed that created issued with numpy ufuncs. The second was that numpy >2 (Specifically in my case 2.0.1) was not being uninstalled correctly when numpy <2 (==1.26.3) was being installed. I've tested this script and running VGGSFM works as intended after these corrections.
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
2 participants
When running the install.sh script I found 2 issues, the first was a conflict with the version of scipy being installed that created issued with numpy ufuncs. The second was that numpy >2 (Specifically in my case 2.0.1) was not being uninstalled correctly when numpy <2 (==1.26.3) was being installed. I've tested this script and running VGGSFM works as intended after these corrections.