Fix deprecated this capture in arvr/projects/ariane/aria_research_kit/projectaria_tools_gen1_legacy/core/data_provider/VrsDataProviderFactory.cpp +1#271
Open
r-barnes wants to merge 1 commit intofacebookresearch:gen1_legacyfrom
Conversation
…/projectaria_tools_gen1_legacy/core/data_provider/VrsDataProviderFactory.cpp +1
Summary:
In the future LLVM will require that lambdas capture `this` explicitly. `-Wdeprecated-this-capture` checks for and enforces this now.
This diff adds an explicit `this` capture to a lambda to fix an issue that presents similarly to this:
```
-> fbcode/path/to/my_file.cpp:66:47: error: implicit capture of 'this' with a capture default of '=' is deprecated [-Werror,-
Wdeprecated-this-capture]
-> detail::createIOWorkerProvider(evb, requestsRegistry_);
-> ^
-> fbcode/path/to/my_file.cpp:61:30: note: add an explicit capture of 'this' to capture '*this' by reference
-> evb->runInEventBaseThread([=, self_weak = std::move(self_weak)]() {
-> ^
-> , this
```
Differential Revision: D82976785
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 26, 2025
…/projectaria_tools_gen1_legacy/core/data_provider/VrsDataProviderFactory.cpp +1 (#271) Summary: Pull Request resolved: #271 In the future LLVM will require that lambdas capture `this` explicitly. `-Wdeprecated-this-capture` checks for and enforces this now. This diff adds an explicit `this` capture to a lambda to fix an issue that presents similarly to this: ``` -> fbcode/path/to/my_file.cpp:66:47: error: implicit capture of 'this' with a capture default of '=' is deprecated [-Werror,- Wdeprecated-this-capture] -> detail::createIOWorkerProvider(evb, requestsRegistry_); -> ^ -> fbcode/path/to/my_file.cpp:61:30: note: add an explicit capture of 'this' to capture '*this' by reference -> evb->runInEventBaseThread([=, self_weak = std::move(self_weak)]() { -> ^ -> , this ``` Differential Revision: D82976785 fbshipit-source-id: fabd5ef094655ac2ca23a173f926dbdb18c5403d
Contributor
|
This pull request has been reverted by e0121ae. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In the future LLVM will require that lambdas capture
thisexplicitly.-Wdeprecated-this-capturechecks for and enforces this now.This diff adds an explicit
thiscapture to a lambda to fix an issue that presents similarly to this:Differential Revision: D82976785