This repository was archived by the owner on Oct 23, 2023. It is now read-only.
Change isNumber check for tensor indexing API #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D39141720 |
raedle
added a commit
to raedle/playtorch
that referenced
this pull request
Aug 30, 2022
Summary: Pull Request resolved: facebookresearch#117 The tensor indexing API as implemented before was relying on exceptions when a prop name was not a number. This fails with RN 0.69.x on iOS with the following error: ``` Exception in HostObject::get for prop 'reshape': stoi: no conversion ``` This change implements an `isNumber` function using the `::isdigit` function Differential Revision: D39141720 fbshipit-source-id: 81e6efa58b0a3b7ffa34677ca722495c50cd2506
raedle
force-pushed
the
export-D39141720
branch
from
622e7ab to
20f5bc0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D39141720 |
raedle
force-pushed
the
export-D39141720
branch
from
20f5bc0 to
8697410
Compare
raedle
added a commit
to raedle/playtorch
that referenced
this pull request
Aug 30, 2022
Summary: Pull Request resolved: facebookresearch#117 The tensor indexing API as implemented before was relying on exceptions when a prop name was not a number. This fails with RN 0.69.x on iOS with the following error: ``` Exception in HostObject::get for prop 'reshape': stoi: no conversion ``` This change implements an `isNumber` function using the `::isdigit` function Differential Revision: D39141720 fbshipit-source-id: 7fb46d8abd82751002555ea079ff9309eda93c12
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D39141720 |
Summary: Pull Request resolved: facebookresearch#117 The tensor indexing API as implemented before was relying on exceptions when a prop name was not a number. This fails with RN 0.69.x on iOS with the following error: ``` Exception in HostObject::get for prop 'reshape': stoi: no conversion ``` This change implements an `isNumber` function using the `::isdigit` function Differential Revision: D39141720 fbshipit-source-id: f5e930acfd39285a91fea362116f5297ab72411a
raedle
force-pushed
the
export-D39141720
branch
from
8697410 to
ffb1cdc
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D39141720 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The tensor indexing API as implemented before was relying on exceptions when a prop name was not a number. This fails with RN 0.69.x on iOS with the following error:
This change implements an
isNumberfunction using the::isdigitfunctionDifferential Revision: D39141720