Skip to content

support active profiler iters #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xunnanxu wants to merge 1 commit into from
Closed

support active profiler iters #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions train/comms/pt/comms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,10 @@
import time

import numpy as np

# pytorch
import torch

from param_bench.train.comms.pt import comms_utils
from param_bench.train.comms.pt.comms_utils import (
bootstrap_info_holder,
commsParamsHolder,
commsParamsHolderBase,
ensureTensorFlush,
MultilineFormatter,
Expand All @@ -33,9 +29,7 @@
commsQuantCollPerfMetrics,
customized_perf_loggers,
)

from param_bench.train.comms.pt.pytorch_backend_utils import (
backendFunctions,
pt2ptPatterns,
supportedC10dBackends,
supportedCollectives,
Expand Down Expand Up @@ -174,6 +168,16 @@ def readArgs(self, parser):
default=None,
help="execute pytorch profiler at specified size",
) # execute pytorch profiler at specified size if applicable
parser.add_argument(
"--profiler-active-iters",
"--pa",
type=int,
required=False,
help=(
"If set, profiler will only record these many iters. "
"Otherwise it records the full --num_iters across one benchmark size iteration."
),
)
parser.add_argument(
"--tag",
type=str,
Expand Down Expand Up @@ -1320,13 +1324,19 @@ def benchComm(self, index, commsParams, backendFuncs):

self.collectiveArgs.data_type = commsParams.data_type
if commsParams.size_start_profiler == curSize:
profiler_active_iters = commsParams.profiler_active_iters
if profiler_active_iters is None:
# not specified in arg
profiler_active_iters = (
self.collectiveArgs.graph_launches
if self.collectiveArgs.graph_launches
else self.collectiveArgs.numIters
)
self.collectiveArgs.enable_profiler = comms_utils.startProfiler(
rank=self.backendFuncs.get_global_rank(),
device=self.collectiveArgs.device,
numWarmupIters=self.collectiveArgs.numWarmupIters,
numIters=self.collectiveArgs.graph_launches
if self.collectiveArgs.graph_launches
else self.collectiveArgs.numIters,
numIters=profiler_active_iters,
)

# self.collectiveArgs has all the information on the experiment.
Expand Down
5 changes: 3 additions & 2 deletions train/comms/pt/comms_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,12 +526,12 @@ def startProfiler(rank: int, device: str, numWarmupIters: int, numIters: int) ->
rank=rank,
device=device,
warmup=numWarmupIters,
iters=numIters,
active=numIters,
)
fbStartProfiler()
return True
else:
logger.debug("Internal profiler is not available, skip...")
logger.warning("Internal profiler is not available, skip...")
return False


Expand Down Expand Up @@ -901,6 +901,7 @@ def __init__(
self.bootstrap_info = bootstrap_info

self.size_start_profiler = args.size_start_profiler
self.profiler_active_iters = args.profiler_active_iters
self.groupRanks = groupRanks

self.include_0B = args.include_0B
Expand Down
Loading