Separate out text and image encoders (#102) #115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37407717 |
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
==========================================
+ Coverage 88.24% 88.37% +0.12%
==========================================
Files 37 39 +2
Lines 2007 2038 +31
==========================================
+ Hits 1771 1801 +30
- Misses 236 237 +1
Continue to review full report at Codecov.
|
ankitade
requested review from
RdoubleA,
apsdehal and
ebsmothers
and removed request for
RdoubleA
ebsmothers
approved these changes
Jun 24, 2022
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37407717 |
ankitade
added a commit
to ankitade/multimodal
that referenced
this pull request
Jun 24, 2022
Summary: Pull Request resolved: facebookresearch#115 Pull Request resolved: facebookresearch#102 Separate out the encoders into their own module without ay logic changes (except fixing 2 minor bugs, see annotations by me) and add tests Test Plan: pytest Reviewed By: ebsmothers Differential Revision: D37407717 Pulled By: ankitade fbshipit-source-id: cd9e120eea4890bb813cb8bbe77577f9e2c77c40
ankitade
force-pushed
the
export-D37407717
branch
from
9ca8423 to
2a2cc73
Compare
Summary: Pull Request resolved: facebookresearch#115 Pull Request resolved: facebookresearch#102 Separate out the encoders into their own module without ay logic changes (except fixing 2 minor bugs, see annotations by me) and add tests Test Plan: pytest Reviewed By: ebsmothers Differential Revision: D37407717 Pulled By: ankitade fbshipit-source-id: bb56e29c798081e8fb8f04ff9307d0f8903628a8
ankitade
force-pushed
the
export-D37407717
branch
from
2a2cc73 to
57f577c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37407717 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pull Request resolved: #102
Separate out the encoders into their own module without ay logic changes (except fixing 2 minor bugs, see annotations by me) and add tests
Test Plan: pytest
Differential Revision: D37407717
Pulled By: ankitade