add assertion for dist_url #157
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: All workers must use the same dist_url / init_method, currently we call `dist_url = f"file:///tmp/mcvdh_dist_file_{uid}_{time.time()}"` to created a shared `dist_url`, but this only works for single machine, add an assertion.
Reviewed By: acisseJZhong
Differential Revision: D46339835
fbshipit-source-id: 6a774c239ec1b08a741717b651e76665ec9b7fc7
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46339835 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: All workers must use the same dist_url / init_method, currently we call
dist_url = f"file:///tmp/mcvdh_dist_file_{uid}_{time.time()}"to created a shareddist_url, but this only works for single machine, add an assertion.Reviewed By: acisseJZhong
Differential Revision: D46339835