Skip to content

go module updates#95

Open
luccabb wants to merge 4 commits intomainfrom
feat/go-module-updates
Open

go module updates#95
luccabb wants to merge 4 commits intomainfrom
feat/go-module-updates

Conversation

@luccabb
Copy link
Member

@luccabb luccabb commented Mar 12, 2026

Summary

  • Renames shelper module path from github.com/fairinternal/fair-cluster-monitoring/shelper to github.com/facebookresearch/gcm/shelper to match the public repo
    • Updates slurmprocessor to reference the renamed shelper module, fixes package declaration from main to slurmprocessor, and removes the internal
      attributesprocessor dependency (used an internal package that external modules can't import)
    • Both modules are now published and fetchable via go get github.com/facebookresearch/gcm/shelper@v0.0.1 and go get
      github.com/facebookresearch/gcm/slurmprocessor@v0.0.1
    • Updates Helm chart values and Kubernetes deployment docs

Test Plan

  • go get github.com/facebookresearch/gcm/shelper@v0.0.1 resolves successfully from a fresh module
    • go get github.com/facebookresearch/gcm/slurmprocessor@v0.0.1 resolves successfully from a fresh module
    • Helm chart deploys correctly with updated values

@github-actions
Copy link

CI Commands

The following CI workflows run automatically on every push and pull request:

Workflow What it runs
GPU Cluster Monitoring Python CI lint, tests, typecheck, format, deb build, pyoxidizer builds
Go packages CI shelper tests, format, lint

The following commands can be used by maintainers to trigger additional tests that require access to secrets:

Command Description Requires approval?
/metaci tests Runs Meta internal integration tests (pytest) Yes — a maintainer must trigger the command and approve the deployment request
/metaci integration tests Same as above (alias) Yes

Note: Only repository maintainers (OWNER association) can trigger /metaci commands. After commenting the command, a maintainer must also navigate to the Actions tab and approve the deployment to the graph-api-access environment before the jobs will run. See the approval guidelines for what to approve or reject.

@luccabb luccabb changed the title Feat/go module updates go module updates Mar 12, 2026
@luccabb
Copy link
Member Author

luccabb commented Mar 12, 2026

@claude can you fix the ci issues?

@claude
Copy link

claude bot commented Mar 12, 2026

Claude finished @luccabb's task in 1m 44s —— View job


Fixing CI Issues

  • Gather context: check CI status
  • Identify failing tests/checks
  • Determine the fix
  • Attempt commit and push — blocked by branch protection ("Meta CLA Check")

Root Cause

Both shelper-tests and shelper-lint are failing because shelper/go.mod is missing the indirect dependencies that testify requires. The CI error is:

go: updates to go.mod needed; to update it:
    go mod tidy

Fix

Apply this change to shelper/go.mod — add the indirect dependencies:

 require github.com/stretchr/testify v1.10.0
+
+require (
+	github.com/davecgh/go-spew v1.1.1 // indirect
+	github.com/pmezard/go-difflib v1.0.0 // indirect
+	gopkg.in/yaml.v3 v3.0.1 // indirect
+)

Or simply run from the repo root:

cd shelper && go mod tidy

Then commit and push the updated shelper/go.mod (and shelper/go.sum if it changes).

Note: I couldn't push this fix directly because pushes to your branch are blocked by the "Meta CLA Check" repository rule. You'll need to apply this change yourself.

View failing CI run | Branch

@meta-codesync
Copy link

meta-codesync bot commented Mar 12, 2026

@luccabb has imported this pull request. If you are a Meta employee, you can view this in D96259734.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant