This repository was archived by the owner on Jun 20, 2025. It is now read-only.
Remove unused variables in fboss/agent/state/Interface.cpp#2395
Open
r-barnes wants to merge 1 commit intofacebookresearch:mainfrom
Open
Remove unused variables in fboss/agent/state/Interface.cpp#2395r-barnes wants to merge 1 commit intofacebookresearch:mainfrom
r-barnes wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
Summary: X-link: facebookresearch/fbpcf#536 LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance. This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code. - If you approve of this diff, please use the "Accept & Ship" button :-) Reviewed By: peygar Differential Revision: D55099975
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55099975 |
r-barnes
force-pushed
the
export-D55099975
branch
from
106e8c5 to
44390a4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55099975 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebookresearch/fbpcf#536
LLVM-15 has a warning
-Wunused-but-set-variablewhich we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with
[[maybe_unused]], mostly in cases where the variable is used, but, eg, in anassertstatement that isn't present in production code.Reviewed By: peygar
Differential Revision: D55099975