This repository was archived by the owner on Oct 21, 2025. It is now read-only.
Open
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D38120426 |
Summary: Pull Request resolved: facebookresearch#380 * Add an `upload_file` API to storage service. * Add an optional metadata param to upload APIs in all relevant interfaces. Most cloud providers support metadata param in their upload APIs, so it should be a fairly generic feature. Some rationales behind these changes: * Since object metadata is a generic feature provided by cloud providers, it makes sense to enable it in storage servic e layer * It does not really make sense to add object metadata in the `copy` API, because we normally don't expect the files to be changed during copying * So I'm adding a new upload_file to support this. We should be calling this API directly if we are specifically uploading files from local to the storage service. reference: relevant [boto3 docs](https://boto3.amazonaws.com/v1/documentation/api/latest/guide/s3-uploading-files.html) for metadata **Next Step**: enable upload api with checksum associated with a file Differential Revision: D38120426 fbshipit-source-id: 2e86ec3083b7d1d7d9b7193d937f16b2cd510492
YigeZhu
force-pushed
the
export-D38120426
branch
from
cae6f47 to
365ce5e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D38120426 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
upload_fileAPI to storage service.Some rationales behind these changes:
copyAPI, because we normally don't expect the files to be changed during copyingreference: relevant boto3 docs for metadata
Differential Revision: D38120426