Skip to content

Conversation

@mialsy
Copy link
Contributor

@mialsy mialsy commented Jul 18, 2022

Description

  • Add frontend for viewing & editing turk list (toggle a turk to be blocked or unblocked)
  • The turk list supports sort, and search by turk id; when editing the list, user need to unlock first
  • Note this frontend change only shows fake data right now

Type of change

Please check the options that are relevant.

  • Bug fix (non-breaking change that fixes an issue)
  • Proposes a change (non-breaking change that isn't necessarily a bug)
  • Refactor
  • New feature (non-breaking change that adds a new functionality)
  • Breaking change (fix or feature that would break some existing functionality downstream)
  • This is a unit test
  • Documentation only change
  • Datasets Release
  • Models Release

Type of requested review

  • I want a thorough review of the implementation.
  • I want a high level review.
  • I want a deep design review.

Before and After

  • Demo:
    • demo_turk_list_manage

Testing

Manually tested

Checklist:

  • I have performed manual end-to-end testing of the feature in my environment.
  • I have added Docstrings and comments to the code.
  • I have made changes to existing documentation where needed.
  • I have added tests that show that the PR is functional.
  • New and existing unit tests pass locally with my changes.
  • I have added relevant collaborators to review the PR before merge.
  • [Polymetis only] I ran on hardware (1) all scripts in tests/scripts, (2) asv benchmarks.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2022
@mialsy mialsy changed the base branch from main to hitl_dashboard_model_viz July 20, 2022 00:55
@snyxan snyxan self-requested a review August 10, 2022 03:38
@mialsy mialsy merged commit e6f4bd2 into hitl_dashboard_model_viz Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants