Skip to content

Support multiple features for PS3I#10

Open
zfscgy wants to merge 3 commits intofacebookresearch:mainfrom
zfscgy:master
Open

Support multiple features for PS3I#10
zfscgy wants to merge 3 commits intofacebookresearch:mainfrom
zfscgy:master

Conversation

@zfscgy
Copy link

@zfscgy zfscgy commented Feb 4, 2021

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs change / refactoring / dependency upgrade

Motivation and Context / Related issue

The previous version for the PS3I protocol only supports one feature for both the company and partner. If the input file contains more than one data column, those extra columns will be ignored. It is caused by the code in protocol/src/cross_psi only considered the first column in the partner/company's data.

How Has This Been Tested (if it applies)

Changing the file etc/input_partner.csv and etc/input_company.csv to have more than 1 data columns will verify my modifications.

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants