This repository was archived by the owner on May 13, 2025. It is now read-only.
Updated sklearn dependency with official package#468
Open
gillesoldano wants to merge 3 commits intofacebookresearch:mainfrom
Open
Updated sklearn dependency with official package#468gillesoldano wants to merge 3 commits intofacebookresearch:mainfrom
gillesoldano wants to merge 3 commits intofacebookresearch:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and Context / Related issue
It replaces the deprecated,unofficial "sklearn" dependency with "scikit-learn"
#454
How Has This Been Tested (if it applies)
I have run the test suite with the command
python3 -u -m unittest discover -s test -p '*test*.py'Checklist
Attached are the Dockerfile of the image I used to run the test suite and the test outputs
Dockerfile.txt
err.txt
out.txt