feat: Add row lineage metadata columns to Iceberg reader#16716
Draft
Joe-Abraham wants to merge 3 commits intofacebookincubator:mainfrom
Draft
feat: Add row lineage metadata columns to Iceberg reader#16716Joe-Abraham wants to merge 3 commits intofacebookincubator:mainfrom
Joe-Abraham wants to merge 3 commits intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
PingLiuPing
reviewed
Mar 11, 2026
|
|
||
| // True if _last_updated_sequence_number is read from the data file (not set | ||
| // as a constant). Set in adaptColumns(). | ||
| bool readLastUpdatedSeqNumFromFile_{false}; |
Collaborator
There was a problem hiding this comment.
Is it equivalent to lastUpdatedSeqNumOutputIndex_.has_value() && dataSequenceNumber_.has_value()?
Collaborator
Author
There was a problem hiding this comment.
Yes, it is equivalent, I have updated it.
| std::optional<int64_t> firstRowId_; | ||
|
|
||
| // True if _row_id should be computed as first_row_id + _pos in next(). | ||
| bool computeRowId_{false}; |
Collaborator
There was a problem hiding this comment.
Is it equivalent to rowIdOutputIndex_.has_value() && firstRowId_.has_value()?
… row ID in IcebergSplitReader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhances read support for Iceberg V3 metadata columns in the Iceberg connector. The modifications add support for hidden Iceberg metadata columns
_row_idand_last_updated_sequence_number, enabling handling of row lineage and schema evolution for Iceberg V3 tables.Part of
Changes
Iceberg Metadata Columns:
_row_idand_last_updated_sequence_numberas hidden metadata columns viaIcebergMetadataColumns.h.icebergRowIdColumnandicebergLastUpdatedSequenceNumberColumn).Reader Enhancements:
IcebergSplitReader.cppto support reading and handling the new metadata columns:_row_idis either read directly from the file or dynamically calculated asfirst_row_id + _pos._last_updated_sequence_numberis filled with the data sequence number if null values are encountered.Test Coverage:
Typo Fixes:
fileFomat_tofileFormat_.