misc: Remove backward compatibility IcebergInsertTableHandle ctor#16153
Closed
PingLiuPing wants to merge 1 commit intofacebookincubator:mainfrom
Closed
misc: Remove backward compatibility IcebergInsertTableHandle ctor#16153PingLiuPing wants to merge 1 commit intofacebookincubator:mainfrom
PingLiuPing wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
PingLiuPing
force-pushed
the
lp_remove_backward_compatibilty_ctor
branch
from
136fbca to
66eea36
Compare
PingLiuPing
force-pushed
the
lp_remove_backward_compatibilty_ctor
branch
from
66eea36 to
578e773
Compare
mbasmanova
added
the
ready-to-merge
|
@kagamiori has imported this pull request. If you are a Meta employee, you can view this in D92189358. |
|
@kagamiori merged this pull request in 9f8cb40. |
Contributor
|
Hi, @PingLiuPing Could you please help check if the Presto build failure is related to this change?
Thanks! |
Collaborator
Author
Hi @zacw7, This is likely not caused by this PR. It should instead be related to this change: #16177, where I removed the dependency of Iceberg from Hive. The error messages suggest that some symbols are missing. Looking at the Prestissimo unit tests, they only link against velox_hive_connector. Since that library no longer contains any Iceberg symbols, this results in the linking error. I’ll submit a PR to fix this in Prestissimo. |
PingLiuPing
added a commit
to IBM/velox
that referenced
this pull request
Feb 6, 2026
…ctor (facebookincubator#16153)" This reverts commit 9f8cb40.
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Feb 6, 2026
…ctor (facebookincubator#16153)" This reverts commit 9f8cb40. Alchemy-item: (ID = 1074) Iceberg staging hub commit 1/7 - 00c222b
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Feb 6, 2026
…ctor (facebookincubator#16153)" This reverts commit 9f8cb40. Alchemy-item: (ID = 1074) Iceberg staging hub commit 1/7 - 00c222b
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Feb 6, 2026
…ctor (facebookincubator#16153)" This reverts commit 9f8cb40. Alchemy-item: (ID = 1074) Iceberg staging hub commit 1/7 - 00c222b
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Feb 6, 2026
…ctor (facebookincubator#16153)" This reverts commit 9f8cb40. Alchemy-item: (ID = 1074) Iceberg staging hub commit 1/7 - 00c222b
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Feb 6, 2026
…ctor (facebookincubator#16153)" This reverts commit 9f8cb40. Alchemy-item: (ID = 1074) Iceberg staging hub commit 1/7 - 00c222b
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Feb 7, 2026
…ctor (facebookincubator#16153)" This reverts commit 9f8cb40. Alchemy-item: (ID = 1074) Iceberg staging hub commit 1/7 - 00c222b
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Feb 7, 2026
…ctor (facebookincubator#16153)" This reverts commit 9f8cb40. Alchemy-item: (ID = 1074) Iceberg staging hub commit 1/7 - 00c222b
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Feb 7, 2026
…ctor (facebookincubator#16153)" This reverts commit 9f8cb40. Alchemy-item: (ID = 1074) Iceberg staging hub commit 1/7 - 00c222b
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Feb 7, 2026
…ctor (facebookincubator#16153)" This reverts commit 9f8cb40. Alchemy-item: (ID = 1074) Iceberg staging hub commit 1/7 - 00c222b
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Feb 7, 2026
…ctor (facebookincubator#16153)" This reverts commit 9f8cb40. Alchemy-item: (ID = 1074) Iceberg staging hub commit 1/7 - 00c222b
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Feb 8, 2026
…ctor (facebookincubator#16153)" This reverts commit 9f8cb40. Alchemy-item: (ID = 1074) Iceberg staging hub commit 1/7 - 00c222b
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Feb 8, 2026
…ctor (facebookincubator#16153)" This reverts commit 9f8cb40. Alchemy-item: (ID = 1074) Iceberg staging hub commit 1/7 - 00c222b
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Feb 9, 2026
…ctor (facebookincubator#16153)" This reverts commit 9f8cb40. Alchemy-item: (ID = 1074) Iceberg staging hub commit 1/7 - 00c222b
wangyum
pushed a commit
to wangyum/velox
that referenced
this pull request
Feb 9, 2026
…ctor (facebookincubator#16153)" This reverts commit 9f8cb40. Alchemy-item: (ID = 1074) Iceberg staging hub commit 1/7 - 00c222b (cherry picked from commit 160e6d4)
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Feb 10, 2026
…ctor (facebookincubator#16153)" This reverts commit 9f8cb40. Alchemy-item: (ID = 1074) Iceberg staging hub commit 1/7 - 00c222b
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Feb 10, 2026
…ctor (facebookincubator#16153)" This reverts commit 9f8cb40. Alchemy-item: (ID = 1074) Iceberg staging hub commit 1/7 - 00c222b
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Feb 11, 2026
…ctor (facebookincubator#16153)" This reverts commit 9f8cb40. Alchemy-item: (ID = 1074) Iceberg staging hub commit 1/7 - 00c222b
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Feb 11, 2026
…ctor (facebookincubator#16153)" This reverts commit 9f8cb40. Alchemy-item: (ID = 1078) Iceberg staging hub commit 1/7 - 00c222b
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Feb 11, 2026
…ctor (facebookincubator#16153)" This reverts commit 9f8cb40. Alchemy-item: (ID = 1078) Iceberg staging hub commit 1/7 - 00c222b
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Feb 12, 2026
…ctor (facebookincubator#16153)" This reverts commit 9f8cb40. Alchemy-item: (ID = 1078) Iceberg staging hub commit 1/7 - 00c222b
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Feb 12, 2026
…ctor (facebookincubator#16153)" This reverts commit 9f8cb40. Alchemy-item: (ID = 1078) Iceberg staging hub commit 1/7 - 00c222b
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Feb 13, 2026
…ctor (facebookincubator#16153)" This reverts commit 9f8cb40. Alchemy-item: (ID = 1078) Iceberg staging hub commit 1/7 - 00c222b
arup-chauhan
pushed a commit
to arup-chauhan/velox
that referenced
this pull request
Feb 23, 2026
…cebookincubator#16153) Summary: PR prestodb/presto#27061 has been merged in Presto. It's safe to remove this code. Pull Request resolved: facebookincubator#16153 Reviewed By: kevinwilfong Differential Revision: D92189358 Pulled By: kagamiori fbshipit-source-id: 968067fd8391c79535d7afac4cbea7a84436b0bc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR prestodb/presto#27061 has been merged in Presto.
It's safe to remove this code.