Added ppc64le architecture#142
Conversation
|
Hi @genisysram! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| - env: | ||
| - JOB_TYPE="clang-format" | ||
| arch: ppc64le | ||
| addons: | ||
| apt: | ||
| packages: | ||
| - clang-format | ||
| script: | ||
| - ./clang-format.sh | ||
| - git diff --exit-code |
There was a problem hiding this comment.
i don't think we need a second clang-format job. Code formatting shouldn't change across archs
Co-authored-by: Daniel Xu <accounts@dxuuu.xyz>
|
Modified travis can you please check and merge. |
danobi
left a comment
danobi
left a comment
There was a problem hiding this comment.
Please fix the build -- I think you broke it
.travis.yml
Outdated
| apt: | ||
| packages: | ||
| - clang-format | ||
|
|
There was a problem hiding this comment.
Remove extra whitespace please
|
Hi |
3 participants
Hi
Here is my contribution to your code, its working good on powersystems.
Thanks for the code, its working good.
What do these changes do?
Added Architecture "ppc64le"
Are there changes in behavior for the user?
No