CMakeLists.txt FetchContent compatibility#167
Open
afrind wants to merge 2 commits intofacebookincubator:mainfrom
Open
CMakeLists.txt FetchContent compatibility#167afrind wants to merge 2 commits intofacebookincubator:mainfrom
afrind wants to merge 2 commits intofacebookincubator:mainfrom
Conversation
Summary: When fizz is consumed via FetchContent, CMAKE_SOURCE_DIR points to the top-level project rather than fizz itself, and folly is built in-tree rather than installed. This diff makes three fixes: 1. Set fizz_SOURCE_DIR as a cache variable so downstream FetchContent consumers can skip find_package(fizz) 2. Guard find_package(folly) behind a check for folly_SOURCE_DIR, allowing folly to be built from source in the same CMake tree 3. Use CMAKE_CURRENT_SOURCE_DIR instead of CMAKE_SOURCE_DIR for FIZZ_BASE_DIR so the path is correct when fizz is a subdirectory Differential Revision: D93366451
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When fizz is consumed via FetchContent, CMAKE_SOURCE_DIR points to the top-level project rather than fizz itself, and folly is built in-tree rather than installed. This diff makes three fixes:
Differential Revision: D93366451