This repository was archived by the owner on Jan 2, 2021. It is now read-only.
WIP Generate VFS for importing header maps. #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main issue here is that the generated VFS is not per-target! It's an auxiliary file that contains information from all targets and goes in a target-independent directory. This doesn't match with either the auxiliary file model or more generally the entire build structure: - Can anything specific to a build affect the VFS? If so, what if separarate builds are running in parallel from the same project? - If two targets in a build are from the same project, they should only need to generate the VFS once, and not more than once.
ghost
added
the
Contributor
|
Does this still need to stay open or can we abandon it? |
|
This might be relevant for #237 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue here is that the generated VFS is not per-target! It's
an auxiliary file that contains information from all targets and goes
in a target-independent directory. This doesn't match with either the
auxiliary file model or more generally the entire build structure:
separarate builds are running in parallel from the same project?
only need to generate the VFS once, and not more than once.