This repository was archived by the owner on Mar 3, 2020. It is now read-only.
Bug 15 fix - 'Pull request' guideline formatting#16
Open
PrashantSunkari wants to merge 1 commit intofacebookarchive:masterfrom
Open
Bug 15 fix - 'Pull request' guideline formatting#16PrashantSunkari wants to merge 1 commit intofacebookarchive:masterfrom
PrashantSunkari wants to merge 1 commit intofacebookarchive:masterfrom
Conversation
Fixing the bug#14.
1. Pull request guidelines points are now formatted in their own line
2. Added a wiki link to indicate what lint roughly means in this context.
Current guideline about lint is not appropriate for this java project.
> 'lint' reference makes more sense for javascript project with grunt.
Example: https://github.com/facebook/react/blob/master/CONTRIBUTING.md#pull-requests
PrashantSunkari
changed the title
Author
|
Sorry for multiple bugs. Didn't realize editing file on the github website with a pull request will create a new bug. My bad |
|
❤ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the bug#15.
Current guideline about lint is not appropriate for this java project.