This repository was archived by the owner on Apr 19, 2023. It is now read-only.
Log exceptions before closing the ThreadLocalPrintStream#162
Open
timcharper wants to merge 1 commit intofacebookarchive:mainfrom
Open
Log exceptions before closing the ThreadLocalPrintStream#162timcharper wants to merge 1 commit intofacebookarchive:mainfrom
timcharper wants to merge 1 commit intofacebookarchive:mainfrom
Conversation
Currently, all output is completely swallowed in the try-with-resources catch statements for NGSession.runImpl, as the output streams are closed before the catch blocks are run. With this change, we add an additional inner try so that we can log the exceptions before the PrintStreams are closed.
styurin
force-pushed
the
master
branch
2 times, most recently
from
495eff8 to
948c51c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, all output is completely swallowed in the try-with-resources catch
statements for NGSession.runImpl, as the output streams are closed before the
catch blocks are run. With this change, we add an additional inner try so that
we can log the exceptions before the PrintStreams are closed.